[Load] Support multi bytes LineDelimiter and ColumnSeparator #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangzhg
changed the title
morningman
added
the
kind/feature
morningman
reviewed
Mar 4, 2021
| _line_delimiter_length = params.line_delimiter_length; | ||
| } else { | ||
| _line_delimiter.push_back(static_cast<char>(params.line_delimiter)); | ||
| _line_delimiter_length = 1; |
There was a problem hiding this comment.
_line_delimiter_length seams useless.
be/src/exec/broker_scanner.cpp
Outdated
| size_t i = 0; | ||
| // TODO improve the performance | ||
| while (i < line.size) { | ||
| if (i + _value_separator.size() <= line.size) { |
There was a problem hiding this comment.
Does _value_separator.size() equals to _value_separator_length?
yangzhg
force-pushed
the
support_multi_byte_seprator
branch
from
16bb95d
to
8d8ca4d
Compare
support multi bytes LineDelimiter and ColumnSeparator
yangzhg
force-pushed
the
support_multi_byte_seprator
branch
from
8d8ca4d
to
64cbdb6
Compare
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Internal][Support Multibytes Separator] doris-1079
support multi bytes LineDelimiter and ColumnSeparator
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...