Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Runtime Filtering for Doris (FE Implement) #6121

Merged
merged 1 commit into from Jul 13, 2021

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Jun 29, 2021

Proposed changes

Fix issue:#6116

  • RuntimeFilterGenerator is used to generate Runtime Filter and assign it to the node that uses Runtime Filter in the query plan.

  • RuntimeFilter represents a filter in the query plan, including the specific properties of the filter, the binding method of expr and tuple slot, etc.

  • RuntimeFilterTarget indicates the filter information provided to ScanNode, including target expr, whether to merge, etc.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

@xinyiZzz xinyiZzz force-pushed the runtime_filter_fe_impl branch 4 times, most recently from 3309fde to e024de1 Compare July 1, 2021 05:10
@xinyiZzz xinyiZzz changed the title [Feature] Support RuntimeFilter in Doris (FE Implement) [Feature] Runtime Filtering for Doris (Background, Configuration, FE Implement, Tuning, Test ) Jul 1, 2021
@xinyiZzz xinyiZzz force-pushed the runtime_filter_fe_impl branch 4 times, most recently from e82330a to fe6f19d Compare July 1, 2021 11:30
@morningman morningman added area/runtime-filter kind/feature Categorizes issue or PR as related to a new feature. labels Jul 1, 2021
@xinyiZzz xinyiZzz changed the title [Feature] Runtime Filtering for Doris (Background, Configuration, FE Implement, Tuning, Test ) [Feature] Runtime Filtering for Doris FE Implement Jul 6, 2021
@xinyiZzz xinyiZzz changed the title [Feature] Runtime Filtering for Doris FE Implement [Feature] Runtime Filtering for Doris (FE Implement) Jul 6, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 12, 2021
@morningman morningman merged commit 394a9a1 into apache:master Jul 13, 2021
@morningman morningman mentioned this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/runtime-filter kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants