Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support exact percentile aggregate function #6410

Merged
merged 8 commits into from
Aug 18, 2021
Merged

[Feature] Support exact percentile aggregate function #6410

merged 8 commits into from
Aug 18, 2021

Conversation

e0c9
Copy link
Contributor

@e0c9 e0c9 commented Aug 10, 2021 •
edited
Loading

Proposed changes

Support to calculate the exact percentile value array of numeric column col at the given percentage(s).

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Feature] Support exact percentile aggregate function #6419) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

@EmmyMiao87
Copy link
Contributor

Please add a issue, Explain roughly the requirements and design

@e0c9
Copy link
Contributor Author

e0c9 commented Aug 10, 2021

Please add a issue, Explain roughly the requirements and design

I have created an issue.

@e0c9 e0c9 changed the title Support exact percentile aggregate function [Feature] Support exact percentile aggregate function Aug 10, 2021
HappenLee
HappenLee reviewed Aug 12, 2021
View reviewed changes
be/src/util/counts.h Outdated Show resolved Hide resolved
be/src/util/counts.h Outdated Show resolved Hide resolved
be/src/exprs/aggregate_functions.cpp Outdated Show resolved Hide resolved
HappenLee
HappenLee reviewed Aug 14, 2021
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please doc of this function

HappenLee
HappenLee approved these changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morningman
morningman approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature. labels Aug 16, 2021
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 16, 2021
@morningman morningman merged commit 66a7a4b into apache:master Aug 18, 2021
songchuangyuan pushed a commit to songchuangyuan/incubator-doris that referenced this pull request Aug 20, 2021
@e0c9
[Feature] Support exact percentile aggregate function (apache#6410)
d8e699c 
Support to calculate the exact percentile value array of numeric column `col` at the given percentage(s).
@morningman morningman mentioned this pull request Oct 10, 2021
Closed
songchuangyuan pushed a commit to songchuangyuan/incubator-doris that referenced this pull request Oct 18, 2021
@e0c9
[Feature] Support exact percentile aggregate function (apache#6410)
f8ec54c 
Support to calculate the exact percentile value array of numeric column `col` at the given percentage(s).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support exact percentile aggregate function
4 participants
@e0c9 @EmmyMiao87 @morningman @HappenLee