Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compile] Support build with clang #7451

Closed
wants to merge 4 commits into from
Closed

Conversation

yiguolei
Copy link
Contributor

Support build Doris BE with clang

Currently, thirdparty could only be build with GCC

@wangbo
Copy link
Contributor

wangbo commented Dec 21, 2021

Maybe provide clang in thrid-party or docker image?
And make build with clang an optional args?

@@ -18,13 +18,6 @@
cmake_minimum_required(VERSION 3.19.2)

# set CMAKE_C_COMPILER, this must set before project command
if (DEFINED ENV{DORIS_GCC_HOME})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be an optional choice?

Copy link
Contributor Author

@yiguolei yiguolei Dec 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, We should remove GCC HOME env.
User should only define CC and CXX env,
for example
export CC= XXXXXXXXXX
export CXX=xxxxxxxxxxxxxx

We define GCC HOME because bitshuffle's build process depend on GCC_HOME/ld. I will rewrite bitshuffle build method use cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to build with clang, then we export CC=XXXX/clang and CXX=XXXXXXX/clang++
If we want to build with gcc, then we export CC=xxxx/gcc and CXX=xxxxx/g++

@yiguolei
Copy link
Contributor Author

Maybe provide clang in thrid-party or docker image? And make build with clang an optional args?

Currently, could only build be with clang, And I don't want it to be an optional args because I think we should use clang as default build tool chain in the future.

@wangbo
Copy link
Contributor

wangbo commented Dec 27, 2021

It seems that --clean and incremental compilation is not support in this pr;
Every time I need to clean manually

@yiguolei yiguolei mentioned this pull request Dec 28, 2021
@yiguolei yiguolei closed this Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants