[feature-wip](iceberg) Step3: Support query iceberg external table #8179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Feb 22, 2022
| <groupId>org.apache.avro</groupId> | ||
| <artifactId>avro</artifactId> | ||
| <version>1.10.1</version> | ||
| </dependency> |
There was a problem hiding this comment.
Add it to fe/pom.xml and reference it here.
| IcebergCatalog icebergCatalog = IcebergCatalogMgr.getCatalog(icebergProperty); | ||
| try { | ||
| this.icebergTable = icebergCatalog.loadTable(TableIdentifier.of(icebergDb, icebergTbl)); | ||
| LOG.info("finished to load table: {}", name); |
There was a problem hiding this comment.
Suggested change
| LOG.info("finished to load table: {}", name); | |
| LOG.info("finished to load iceberg table: {}", name); |
| this.icebergTable = icebergCatalog.loadTable(TableIdentifier.of(icebergDb, icebergTbl)); | ||
| LOG.info("finished to load table: {}", name); | ||
| } catch (Exception e) { | ||
| LOG.warn("failed to load table {} from {}", name, icebergProperty.getHiveMetastoreUris(), e); |
There was a problem hiding this comment.
Suggested change
| LOG.warn("failed to load table {} from {}", name, icebergProperty.getHiveMetastoreUris(), e); | |
| LOG.warn("failed to load iceberg table {} from {}", name, icebergProperty.getHiveMetastoreUris(), e); |
| targetTable = icebergTable; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Add a example in comment about the format for returned url
There was a problem hiding this comment.
And what if the iceberg is located on AWS S3 or other oss, instead of hdfs?
| fileStatusesList.add(fileStatuses); | ||
| filesAdded += fileStatuses.size(); | ||
| for (TBrokerFileStatus fstatus : fileStatuses) { | ||
| LOG.info("Add file status is {}", fstatus); |
There was a problem hiding this comment.
Suggested change
| LOG.info("Add file status is {}", fstatus); | |
| LOG.debug("Add file status is {}", fstatus); |
| @@ -17,8 +17,8 @@ | |||
|
|
|||
| package org.apache.doris.qe; | |||
|
|
|||
| import avro.shaded.com.google.common.collect.Maps; | |||
| import avro.shaded.com.google.common.collect.Sets; | |||
| import com.google.common.collect.Maps; | |||
There was a problem hiding this comment.
pay attention to import order
Change-Id: I2b7a4ae72df4e24e75d7151ab9644e6adc04d58d
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Mar 14, 2022
1. Add Iceberg scan node 2. Add Iceberg/Hive table type in thrift 3. Support querying Iceberg tables of format types `parquet` and `orc`
morningman
added
dev/merged-1.0.1-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #8178
Problem Summary:
parquetandorcChecklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...