Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: getChannel -> getChannel() #9217

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

stalary
Copy link
Contributor

@stalary stalary commented Apr 25, 2022

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@lide-reed lide-reed merged commit 7226089 into apache:master Apr 25, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 25, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
(cherry picked from commit 7226089)
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 26, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
(cherry picked from commit 7226089)
@morningman morningman added dev/backlog waiting to be merged in future dev branch dev/1.0.1-deprecated should be merged into dev-1.0.1 branch dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/backlog waiting to be merged in future dev branch dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 26, 2022
morningman pushed a commit that referenced this pull request Apr 26, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
@stalary stalary deleted the hotfix/channel branch May 6, 2022 07:49
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
Co-authored-by: Rongqian Li <rongqian_li@idgcapital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants