Changes from review comments

apache · Mar 21, 2022 · 82e1055 · 82e1055
1 parent 4a63622
commit 82e1055
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatConfig.java b/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatConfig.java
@@ -61,7 +61,7 @@ public TextFormatConfig(
       @JsonProperty("extractHeader") Boolean extractHeader) {
     this.extensions = extensions == null ?
         ImmutableList.of() : ImmutableList.copyOf(extensions);
-    this.lineDelimiter = lineDelimiter == null ? "\n" : lineDelimiter;
+    this.lineDelimiter = Strings.isNullOrEmpty(lineDelimiter) ? "\n" : lineDelimiter;
     this.fieldDelimiter = Strings.isNullOrEmpty(fieldDelimiter) ? ',' : fieldDelimiter.charAt(0);
     this.quote = Strings.isNullOrEmpty(quote) ? '"' : quote.charAt(0);
     this.escape = Strings.isNullOrEmpty(escape) ? '"' : escape.charAt(0);
@@ -70,10 +70,6 @@ public TextFormatConfig(
     this.extractHeader = extractHeader == null ? false : extractHeader;
   }
 
-  public TextFormatConfig() {
-    this(null, null, null, null, null, null, null, null);
-  }
-
   public List<String> getExtensions() { return extensions; }
   public String getLineDelimiter() { return lineDelimiter; }
   public char getFieldDelimiter() { return fieldDelimiter; }

diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java b/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
@@ -110,10 +110,6 @@ public ManagedReader newReader(FileSchemaNegotiator negotiator) throws EarlyEofE
     }
   }
 
-  public TextFormatPlugin(String name, DrillbitContext context, Configuration fsConf, StoragePluginConfig storageConfig) {
-     this(name, context, fsConf, storageConfig, new TextFormatConfig());
-  }
-
   public TextFormatPlugin(String name, DrillbitContext context,
       Configuration fsConf, StoragePluginConfig config,
       TextFormatConfig formatPluginConfig) {