DRILL-5864 Selecting a non-existing field from a MapR-DB JSON table fai… #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
HanumathRao
force-pushed
the
DRILL-5864
branch
from
f39aeca
to
8f817e3
Compare
HanumathRao
changed the title
|
Merged in 125a927. @HanumathRao pls close the PR (for some reason I don't have permission). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ls with NPE
@amansinha100 @adityakishore
These changes are about having a special handling in case if the query contains no fields that are present in the maprdb json table. I have looked at other readers which are having this special handling. Here are the readers which do the special handling now.
JSONRecordReader and ParquetRecordReader.
With out these changes the upstream operator are getting not populated vectors and hence they throw nullpointer exception.