DRILL-6088: MainLoginPageModel errors out when http.auth.mechanisms i… #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arina-ielchiieva - Can you please help to review this PR ? |
arina-ielchiieva
approved these changes
Jan 18, 2018
|
|
||
| private final String error; | ||
|
|
||
| private final boolean authEnabled; | ||
|
|
||
| private final DrillConfig config; |
There was a problem hiding this comment.
It looks like you are using config only in constructor, so it may not store it in class.
added 2 commits
January 18, 2018 20:06
|
@arina-ielchiieva - I have rebased the commit's on latest master and made the change as suggested. I have also made the MainLoginPageModel class public since it was causing the issue without that at runtime. Looks like during testing I kept it as public but later while opening the PR I might have changed it to package-private and was seeing issues today again during test. |
|
+1, LGTM. |
amansinha100
pushed a commit
to amansinha100/drill
that referenced
this pull request
Jan 21, 2018
…s not configured DRILL-6088: Update based on review feedback close apache#1092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s not configured