DRILL-6243: Added alert box to confirm shutdown of drillbit after clicking shutdown button #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvjyothsna
changed the title
|
@sohami Please review |
…cking shutdown button
sohami
reviewed
Mar 19, 2018
| complete: function(data) { | ||
| alert(data.responseJSON["response"]); | ||
| button.prop('disabled',true).css('opacity',0.5); | ||
| } |
There was a problem hiding this comment.
please fix indentation here and below. Also add the error: callback for Ajax request.
Like alert with received error ?
sohami
reviewed
Mar 19, 2018
| button.prop('disabled',true).css('opacity',0.5); | ||
| } | ||
| }); | ||
| if (confirm("Click ok to shutdown")) { |
There was a problem hiding this comment.
Message should be more of like "Are you sure you want to shutdown Drillbit running on + location.host + node ?"
|
+1 LGTM. Thanks for making the changes. |
vdiravka
pushed a commit
to vdiravka/drill
that referenced
this pull request
Mar 24, 2018
…cking shutdown button closes apache#1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cking shutdown button