DRILL-6447: Fixed a sanity check condition #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arina-ielchiieva can you please review this fix? Thanks! |
vrozov
reviewed
May 26, 2018
| @@ -445,8 +445,8 @@ public void clear(){ | |||
| * @throws IOException An IO related condition | |||
| */ | |||
| void resetDefinitionLevelReader(int skipCount) throws IOException { | |||
| if (parentColumnReader.columnDescriptor.getMaxDefinitionLevel() != 0) { | |||
| throw new UnsupportedOperationException("Unsupoorted Operation"); | |||
| if (parentColumnReader.columnDescriptor.getMaxDefinitionLevel() > 1) { | |||
There was a problem hiding this comment.
This is already part of Parquet version upgrade (see PR #1259), no need to fix it.
|
@sachouche can we add the JIRA number in the title as well? |
sachouche
changed the title
|
@sachouche any update based to Vlad's feedback? |
|
@arina-ielchiieva We agreed that this PR can be closed and I'll add fix for |
|
Sounds good. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Parquet bulk reader asserted that resetting a Page Definition Level should be performed only for a Flat Schema; the check should have tested for a value of zero or one.