DRILL-1942-hygiene: #133
Closed
DRILL-1942-hygiene: #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add AutoCloseable to many classes - minor fixes - formatting
cwestin
force-pushed
the
hygiene-beta
branch
from
904658e
to
baca735
Compare
| if (managedBuffers.allocated[i]) { | ||
| ((DrillBuf)mbuffers[i]).release(); | ||
| ((DrillBuf) mbuffers[i]).release(1); |
There was a problem hiding this comment.
why not just call release(), it calls release(1) internally ?
There was a problem hiding this comment.
It saves a function call; seems desirable in tight loops and low-level value vector situations.
|
+1 LGTM |
adeneche
pushed a commit
to adeneche/incubator-drill
that referenced
this pull request
Sep 11, 2015
- add AutoCloseable to many classes - minor fixes - formatting this closes apache#133
adeneche
pushed a commit
to adeneche/incubator-drill
that referenced
this pull request
Sep 11, 2015
- add AutoCloseable to many classes - minor fixes - formatting this closes apache#133
adeneche
pushed a commit
to adeneche/incubator-drill
that referenced
this pull request
Sep 14, 2015
- add AutoCloseable to many classes - minor fixes - formatting this closes apache#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-1942-hygiene (another preparatory patch):
- add AutoCloseable to some classes
- minor fixes
- formatting
Unit tests pass
Regression suite passed except for some window function queries (this branch needs to get rebased to pick up that code), and the known fragment distribution timeout.