DRILL-6610: Add support for Minimum TLS restriction. #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohami
reviewed
Aug 22, 2018
| } else { | ||
| return boost::asio::ssl::context::tlsv12; | ||
| } | ||
| } | ||
|
|
||
| /// @brief Applies Minimum TLS protocol restrictions. |
There was a problem hiding this comment.
please add a comment saying version tlsv11+ means tls version 1.1 or higher
| return SSL_OP_NO_TLSv1; | ||
| } else if (in_ver == "tlsv12+") { | ||
| return (SSL_OP_NO_TLSv1 | SSL_OP_NO_TLSv1_1); | ||
| } |
There was a problem hiding this comment.
Looks like SSL_OP_NO_TLSv1 and others are getting deprecate with 1.1.0 openssl. Please see here.
There was a problem hiding this comment.
I've added a note of that in the comments
| return (SSL_OP_NO_TLSv1 | SSL_OP_NO_TLSv1_1); | ||
| } | ||
| #endif | ||
| return 0; |
There was a problem hiding this comment.
I think by default we can always return SSL_OP_NO_SSLv3 even though we are setting options to context for no_sslv2 | no_sslv3;
|
@superbstreak Could you please respond to review comments? In that case there these changes can be included to the Apache Drill 1.15 release version. |
superbstreak
force-pushed
the
DRILL-6610
branch
from
cccc659
to
56fab19
Compare
sohami
approved these changes
Nov 5, 2018
mattpollack
pushed a commit
to mattpollack/drill
that referenced
this pull request
Feb 25, 2019
lushuifeng
pushed a commit
to lushuifeng/drill
that referenced
this pull request
Jun 21, 2019
xiangt920
pushed a commit
to xiangt920/drill
that referenced
this pull request
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.