Update Calcite and Add Test cases #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final String[] expectedPlan = {"Window.*partition \\{\\} order by \\[0\\].*COUNT\\(\\)", | ||
| "Scan.*columns=\\[`o_custkey`, `o_orderpriority`\\]"}; | ||
| final String[] excludedPatterns = {"Scan.*columns=\\[`\\*`\\]"}; | ||
| test("alter session set `planner.slice_target` = 1"); |
There was a problem hiding this comment.
This line seems to be redundant, since line 430 set the same option, right?
|
+1 |
| * being DrillPBError.ErrorType.VALIDATION the given message. | ||
| * @param testSqlQuery Test query | ||
| */ | ||
| protected static void validationErrorHelper(final String testSqlQuery) throws Exception { |
There was a problem hiding this comment.
Can you use thrownException.expect(new UserExceptionMatcher(VALIDATION, "...")); in unit tests that use this method (rather than defining and using this method)?
There was a problem hiding this comment.
Oh. cool. I have never known we could do that :)
hsuanyi
force-pushed
the
DRILL-TEST
branch
2 times, most recently
from
e05b84c
to
99206a4
Compare
|
Addressed jinfengni and sudheeshkatkam 's comments, Thanks!!! |
|
Will report after done with the tests |
Fix is in CALCITE-841
Fix is in CALCITE-844
Fixes are in CALCITE-634, CALCITE-613, CALCITE-662
…ValidationException is thrown from Calcite
Fix is in CALCITE-820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.