Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-6988: Utility of the too long error message when syntax error #1753

Closed
wants to merge 1 commit into from

Conversation

dgrinchenko
Copy link
Contributor

JIRA DRILL-6988

  • Adding Drill wrapper around SqlparseException to customize produced by Calcite messages
  • Fix Drill SQL parse exception formatter to calculate proper position for "^" character

- Adding Drill wrapper around SqlparseException to customize produced by Calcite messages
- Fix Drill SQL parse exception formatter to calculate proper position for "^" character
@arina-ielchiieva
Copy link
Member

@dgrinchenko could you please add screenshot, how error will look like?

@dgrinchenko
Copy link
Contributor Author

@vvysotskyi
Please check the picture here

Also it is attached to the task jira.

Copy link
Member

@vvysotskyi vvysotskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrinchenko, thanks for fixing error message, +1

sohami pushed a commit to sohami/drill that referenced this pull request May 2, 2019
- Adding Drill wrapper around SqlparseException to customize produced by Calcite messages
- Fix Drill SQL parse exception formatter to calculate proper position for "^" character
closes apache#1753
@sohami sohami closed this in d897f70 May 3, 2019
lushuifeng pushed a commit to lushuifeng/drill that referenced this pull request Jun 21, 2019
- Adding Drill wrapper around SqlparseException to customize produced by Calcite messages
- Fix Drill SQL parse exception formatter to calculate proper position for "^" character
closes apache#1753
xiangt920 pushed a commit to xiangt920/drill that referenced this pull request Dec 26, 2019
- Adding Drill wrapper around SqlparseException to customize produced by Calcite messages
- Fix Drill SQL parse exception formatter to calculate proper position for "^" character
closes apache#1753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants