New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-6225: Add support for boost 1.68 with openSSL 1.1.0/1.1.1 support #1817
Conversation
Updating my drill branch
@debraj92 please squash the commits and address protobuf job failures - https://travis-ci.org/apache/drill/jobs/552040788. |
3488a51
to
4814a98
Compare
@debraj92 there are some failures on protobuf job. Could you please check? |
@debraj92 for me the change is unclear:
|
Hi @dgrinchenko , Actually the change is incomplete because I ran into a problem with the travis building. Before explaining the problem, let me answer your questions and make the idea clear:
Now, the problem. To get travis to build drill client code I would have to specify the location for downloading the boost 1.68 static libs. I could not find a repo from where I can do this and hence the change in the travis.yml file is not accurate. One option is to build boost from source but that would unnecessarily slow down the build. I also tried other boost versions (1.65, 1.67) but travis build did not succeed. Not sure how to proceed from here now. |
@debraj92 please read carefully point 2 of my comment, it describes why travis failing for you. Here is the max version of libboost available for the travis. The another problem - if you decide to build own version of libboost, then it would need to be linked statically to the client, to not interference with already installed system version of libboost, otherwise your patch would change the minimal system version requirements for building and using drill client |
Hi , |
The change is to upgrade boost to the version 1.68. This ensures support for openssl 1.1.1 and 1.1.0.