DRILL-7497: Fix warnings when starting Drill on Windows using Java 11 #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvysotskyi
force-pushed
the
DRILL-7497
branch
from
0ac8f1e
to
8bfd5fc
Compare
vvysotskyi
force-pushed
the
DRILL-7497
branch
from
8bfd5fc
to
9e1fd8a
Compare
|
+1, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira - DRILL-7497.
%DRILL_SHELL_JAVA_OPTS%is expanded when if block is parsed, so as a result, every next line of the if block will override the value set in the previous one.Replaced it with a single assignment.