DRILL-7514: Update Apache POI to Latest Version #1991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvysotskyi
reviewed
Feb 20, 2020
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
Outdated
Show resolved
Hide resolved
vvysotskyi
reviewed
Feb 20, 2020
|
@vvysotskyi |
|
@cgivre, please address this comment: #1991 (comment) |
vvysotskyi
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
@cgivre, thanks for the PR and making changes, +1.
It is great that the newer version will consume memory more efficiently.
Also, please squash the commits.
|
@vvysotskyi Thanks for the review. Commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-7514: Update Apache POI to Latest Version
Description
Drill's Excel Format Plugin uses Apache POI to parse Excel files. While this reader is effective in that it parses formulae and data types, it uses memory inefficiently and will struggle to read very large Excel files.
The latest version of POI addresses some of the memory issues and hopefully Drill will be able to query larger Excel files without running out of memory.
This PR updates Drill to use the latest version of Apache POI and also updates the User Agent Parser to a more recent version.
There was a minor change to the POI's behavior with respect to empty sheets, so I had to enclose a line in a
try/catchblock.Documentation
No user visible changes.
Testing
All relevant unit tests run and passed.