DRILL-7587: Fix ValuesPrule distribution trait type #2002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-rogers
reviewed
Feb 29, 2020
| call.transformTo(new ValuesPrel(rel.getCluster(), rel.getRowType(), rel.getTuples(), | ||
| rel.getTraitSet().plus(Prel.DRILL_PHYSICAL), rel.getContent())); | ||
| rel.getTraitSet().plus(Prel.DRILL_PHYSICAL).plus(DrillDistributionTrait.SINGLETON), rel.getContent())); |
There was a problem hiding this comment.
Maybe add a comment that explains the reason, such as the PR explanation?
There was a problem hiding this comment.
Sure, added explanation comments.
arina-ielchiieva
force-pushed
the
DRILL-7587
branch
from
1711e06
to
fa65a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-7587: Fix ValuesPrule distribution trait type
Description
Incorrect result was retuning due to absence of singleton distribution trait which forces to run such type of queries only in one fragment.
Documentation
NA
Testing
Add unit tests and run full test suit, including Functional and Advanced tests.