DRILL-7631: Updates to the Json Structure Parser #2016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised how "look-ahead" works. Added support for unknown types.
vvysotskyi
reviewed
Mar 10, 2020
There was a problem hiding this comment.
@paul-rogers, thanks for making the pull request!
I have added a couple of minor comments, could you please take a look?
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ObjectListener.java
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDefFactory.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ObjectListener.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDef.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/ValueDef.java
Outdated
Show resolved
Hide resolved
|
@vvysotskyi, thanks much for your review! Addressed the review comments. |
vvysotskyi
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-7631: Updates to the Json Structure Parser
Description
The JSON structure parser converts JSON tokens from the Jackson JSON parser into a structure consisting of values, arrays and objects. The structure parser handles the JSON aspects. An associated set of listeners converts JSON values to some other format (such as to vectors via the column writers.) This PR covers only the structure parser.
Work to create a new JSON record reader using this parser revealed several required revisions:
ValueDefvalue description.Integer.Note that, at present, no code uses the JSON structure parser. That code will come in a later PR.
Documentation
None
Testing
Expanded an reran the associated unit tests. Moved the unit tests so that they are in the same package as the code.