DRILL-7739: Allow implicit casts from required to nullable data type #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanel
reviewed
May 24, 2020
| matchedFuncHolder.getNullHandling() == FunctionTemplate.NullHandling.NULL_IF_NULL) || | ||
| matchedFuncHolder.isFieldReader(i)) { | ||
| if (paramType.getMode() == DataMode.OPTIONAL |
There was a problem hiding this comment.
This could be refactored to separate function. Same construct down below.
sanel
approved these changes
May 24, 2020
|
@sanel, thanks for the review, I have made requested changes, please take a look. |
|
All good! Thanks @vvysotskyi |
sanel
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-7739: Allow implicit casts from required to nullable data type
Description
Added code to insert a cast of function argument to nullable type for the case when requiring nullable one, but required is provided.
Documentation
NA
Testing
Reran all unit tests.