Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-7793: Fix syntax error in "drill-config.sh" #2104

Merged
merged 1 commit into from Oct 1, 2020

Conversation

gdubya
Copy link
Contributor

@gdubya gdubya commented Sep 21, 2020

The drill-config.sh has a syntax error on line 144 with the usage of "let". The command following let should be enclosed in quotes, otherwise the following syntax error occurs:

/home/someone/proj/apache-drill-1.17.0/bin/drill-config.sh: line 144: let: lineCount=: syntax error: operand expected (error token is "=")

The drill-config.sh has a syntax error on line 144 with the usage of "let". The command following let should be enclosed in quotes, otherwise the following syntax error occurs:
/home/someone/proj/apache-drill-1.17.0/bin/drill-config.sh: line 144: let: lineCount=: syntax error: operand expected (error token is "=")
@gdubya
Copy link
Contributor Author

gdubya commented Sep 21, 2020

I'm not sure why this caused the build to fail.

@cgivre
Copy link
Contributor

cgivre commented Sep 25, 2020

I think the CI is just timing out.

@cgivre cgivre self-requested a review September 25, 2020 14:52
@cgivre cgivre added the bug label Sep 25, 2020
Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@cgivre
Copy link
Contributor

cgivre commented Sep 30, 2020

@gdubya
Is there a JIRA for this? If not, could you please create a JIRA issue at issues.apache.org and then put a link in the title of the PR? Once that's done, I'll commit.
Thanks!

@gdubya gdubya changed the title Fix syntax error in "drill-config.sh" DRILL-7793: Fix syntax error in "drill-config.sh" Oct 1, 2020
@gdubya
Copy link
Contributor Author

gdubya commented Oct 1, 2020

There was no JIRA issue. Created DRILL-7793 👍

@cgivre
Copy link
Contributor

cgivre commented Oct 1, 2020

Thanks @gdubya!

@cgivre cgivre merged commit 2eb6979 into apache:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants