DRILL-8121: Add UserSession to StoragePlugins #2475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
access-controls
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8121: Add UserSession to StoragePlugins
Description
One of the major limitations of Drill is that per-user credentials are not supported in non-Hadoop, or file system storage plugins. In conducting experiments, one of the major challenges preventing this was that there was no reliable way for a storage plugin to obtain the username of the user who submitted the query.
This PR represents the first step in making this possible by passing the UserSession object down to the storage plugin instance. Thus for each query, the storage plugin can obtain the active user id. This does not affect any current Drill behavior, but will make it possible to implement per-user credentials for plugins such as JDBC, Splunk, ElasticSearch and others that do not have the concept of user impersonation.
Documentation
No user facing changes
Testing
Added unit tests.