DRILL-8220: Add User Translation Support for OAuth Enabled Plugins #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
enhancement
cgivre
force-pushed
the
oauth_per_user_creds
branch
from
baccc47
to
1cc0a20
Compare
cgivre
force-pushed
the
oauth_per_user_creds
branch
from
caf69f4
to
335dc63
Compare
jnturton
requested changes
May 16, 2022
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/OAuthRequests.java
Outdated
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/PluginConfigWrapper.java
Show resolved
Hide resolved
|
@jnturton Thanks for the review comments. I changed the |
jnturton
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8220: Add User Translation Support for OAuth Enabled Plugins
Description
This PR adds support for individual users to provide their own credentials for plugins that use OAuth 2.0 as a means of authorization and authentication. Currently, only the HTTP storage plugin supports OAuth, however, this PR moves some of the core features out of the HTTP plugin so that other plugins can access this.
As a part of this work, this PR adds additional REST endpoints to the
credentialspage.Documentation
Will add complete documentation once final version is merged. The only thing a user will notice is that in the Credentials page, if a plugin uses OAuth2.0, the button will say
Authorizeinstead ofAdd Credentials.Testing
Manually tested and added unit tests.