DRILL-8475: Update the binary distributions LICENSE #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't automatically generate license headers anywhere else and RAT is inecessary and sufficient for _checking_ headers.
jnturton
added
documentation
jnturton
changed the title
jnturton
changed the title
Note that the binary dist license will differ depending on the build profile used e.g. `mvn -Phadoop-2`
jnturton
force-pushed
the
8475-binary-license
branch
from
3a08367
to
02dc7ee
Compare
|
|
|
@jnturton Are we closed to merging this? |
cgivre
approved these changes
Feb 23, 2024
jnturton
added a commit
to jnturton/drill
that referenced
this pull request
Apr 12, 2024
jnturton
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8475: Update the binary distributions LICENSE
Description
The LICENSE file included in the binary distributions of Drill becomes an artifact that is generated automatically by the org.codehaus.mojo:license-maven-plugin (and so is no longer part of the Git source tree). The generated LICENSE is therefore profile dependent, e.g. the Hadoop 2 build of Drill will (as it must) carry a different LICENSE file. Dependencies that it cannot detect are kept in the LICENSE-base.txt file which is combined with the generated license notices by a new Freemarker template. Various other dependency related changes are included as part of this work. It is still possible that fat jars have introduced hidden depedencies but I propose that those are analysed in a subsequent Jira issue.
Documentation
Comments and updated dev docs.
Testing
Comparison of the jars/ directory of a Drill build against the generated LICENSE file to check that every bundled jar has a license notice in LICENSE. The generated Hadoop 3 LICENSE at the time of writing is attached, the new content appearing after the Apache 2.0 license itself.
Connect to Drill using the pruned JDBC driver wuth TLS enabled and search inside the driver JAR for any references to the pruned dependencies.
LICENSE.txt