DRILL-4693: Ensure final column re-ordering is done if any select li… #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t expression is convert_fromjson.
|
@jinfengni could you pls review ? |
| for (RexNode expr : this.exps) { | ||
| if (expr.getKind() == SqlKind.OTHER_FUNCTION && | ||
| expr instanceof RexCall && | ||
| ((RexCall) expr).getOperator().getName().equalsIgnoreCase("CONVERT_FROMJSON")) { |
There was a problem hiding this comment.
Can you pls add a comment that convert_fromjson() currently can only used as a top level function (it can not be nested in other function)? Otherwise, we have to walk through the expression tree to check the existence of this function.
Tried with convert_to(convert_from(t.jsonstr, 'json'), 'json'), and it hit NPE in execution.
There was a problem hiding this comment.
Will add a comment. You should probably file a JIRA for the NPE.
|
LGTM. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st expression is convert_fromjson.