DRILL-4833: Handle union-all physical operator during the excessive e… #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xchange identification phase.
|
@jinfengni could you pls review this patch ? I have put some explanation in the JIRA itself. |
|
|
||
| // width of the major fragment that contains union-all should be the maximum | ||
| // width of all its inputs | ||
| s.setMaxWidth(maxStat.getMaxWidth()); |
There was a problem hiding this comment.
In addition to maxWidth, should we maintain maxRows as well for the stat object of Union-all operator?
There was a problem hiding this comment.
After discussion with @amansinha100 , I realized that maxRows has been taken care of for Union-All operator, since for union-all, maxRows will be sum of both children's maxRows.
|
+1 |
|
Closing based on comments in DRILL-4833. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xchange identification phase.