DRILL-3313: Eliminate redundant #load methods and unit-test loading & exporting of vectors #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exporting of vectors
|
Apologies for the forthcoming double comments. I forgot to make comments on the pull request and instead was viewing the individual commit. These comments are nicely aggregated on the github IU, but are not currently picked up the the JIRA bot to copy the comments to the issue report. I will be duplicating my comments on the same lines they were on the individual commit on the pull request summary diff to make sure they get copied over. |
|
|
||
| @Override | ||
| public void load(SerializedField metadata, DrillBuf buffer) { | ||
| assert this.field.matches(metadata) : String.format("The field %s doesn't match the provided metadata %s.", this.field, metadata); |
There was a problem hiding this comment.
Are you sure we want to actually remove this assert, are we certain that it is no longer useful for catching inconsistent state problems?
Closed
|
This commit was merged as part of this PR #134. So closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.