Link to Druid-specific security page #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the 'Security' link on the homepage point to the Druid-specific security overview page, which contains relevant information about the Druid security trust model, and also contains the information on how to report security issues.
| @@ -20,7 +20,7 @@ | |||
| <a href="https://www.apache.org/events/current-event" target="_blank">Events</a> | |||
| <a href="https://www.apache.org/licenses/" target="_blank">License</a> | |||
| <a href="https://www.apache.org/foundation/thanks.html" target="_blank">Thanks</a> | |||
| <a href="https://www.apache.org/security/" target="_blank">Security</a> | |||
| <a href="https://druid.apache.org/docs/latest/operations/security-overview.html" target="_blank">Security</a> | |||
There was a problem hiding this comment.
this is under Apache section. So it makes sense to link to Apache Security page.
There was a problem hiding this comment.
Do you have an alternative suggestion?
While it's not entirely uncommon for Apache pages to link to project-specific security pages from the 'Security' link in the 'Apache' section (e.g. https://ofbiz.apache.org/, https://pdfbox.apache.org/), I agree it's a bit odd. I'd like to make the project-specific page more prominent, though. Do you think it could be a top-level item?
There was a problem hiding this comment.
We can put the link in "Learn more" section on home page. @vogievetsky sounds good to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the 'Security' link on the homepage point to the Druid-specific security overview page, which contains relevant information about the Druid security trust model, and also contains the information on how to report security issues.