fix braces with nulls

apache · May 16, 2024 · 7d4149c · 7d4149c
1 parent b718b1f
commit 7d4149c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/web-console/src/utils/table-helpers.ts b/web-console/src/utils/table-helpers.ts
@@ -55,11 +55,11 @@ export function getNumericColumnBraces(
     queryResult.header.forEach((column, i) => {
       if (!oneOf(column.nativeType, 'LONG', 'FLOAT', 'DOUBLE')) return;
       const formatter = columnHints?.get(column.name)?.formatter || formatNumber;
-      const brace = filterMap(rows, row =>
+      const braces = filterMap(rows, row =>
         oneOf(typeof row[i], 'number', 'bigint') ? formatter(row[i]) : undefined,
       );
-      if (rows.length === brace.length) {
-        numericColumnBraces[i] = brace;
+      if (braces.length) {
+        numericColumnBraces[i] = braces;
       }
     });
   }

diff --git a/web-console/src/views/workbench-view/result-table-pane/result-table-pane.tsx b/web-console/src/views/workbench-view/result-table-pane/result-table-pane.tsx
@@ -620,7 +620,7 @@ export const ResultTablePane = React.memo(function ResultTablePane(props: Result
                       {numericColumnBraces[i] ? (
                         <BracedText
                           className="table-padding"
-                          text={formatNumber(value)}
+                          text={typeof value === 'number' ? formatNumber(value) : String(value)}
                           braces={numericColumnBraces[i]}
                           padFractionalPart
                         />