Skip to content

Commit

Permalink
Capitalize keywords in SQL auto complete (#7462)
Browse files Browse the repository at this point in the history
* Split commit; keep auto complete only

* Add comment
  • Loading branch information
shuqi7 authored and clintropolis committed Apr 18, 2019
1 parent f06f0c3 commit 99ddce1
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions web-console/src/components/sql-control.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,28 @@ export class SqlControl extends React.Component<SqlControlProps, SqlControlState
};
}

private replaceDefaultAutoCompleter = () => {
/*
Please refer to the source code @
https://github.com/ajaxorg/ace/blob/9b5b63d1dc7c1b81b58d30c87d14b5905d030ca5/lib/ace/ext/language_tools.js#L41
for the implementation of keyword completer
*/
const keywordCompleter = {
getCompletions: (editor: any, session: any, pos: any, prefix: any, callback: any) => {
if (session.$mode.completer) {
return session.$mode.completer.getCompletions(editor, session, pos, prefix, callback);
}
const state = editor.session.getState(pos.row);
let keywordCompletions = session.$mode.getCompletions(state, session, pos, prefix);
keywordCompletions = keywordCompletions.map((d: any) => {
return Object.assign(d, {name: d.name.toUpperCase(), value: d.value.toUpperCase()});
});
return callback(null, keywordCompletions);
}
};
langTools.setCompleters([langTools.snippetCompleter, langTools.textCompleter, keywordCompleter]);
}

private addDatasourceAutoCompleter = async (): Promise<any> => {
const datasourceResp = await axios.post('/druid/v2/sql', { query: `SELECT datasource FROM sys.segments GROUP BY 1`});
const datasourceList: any[] = datasourceResp.data.map((d: any) => {
Expand Down Expand Up @@ -169,6 +191,7 @@ export class SqlControl extends React.Component<SqlControlProps, SqlControlState

private addCompleters = async () => {
try {
this.replaceDefaultAutoCompleter();
this.addFunctionAutoCompleter();
await this.addDatasourceAutoCompleter();
await this.addColumnNameAutoCompleter();
Expand Down

0 comments on commit 99ddce1

Please sign in to comment.