Skip to content

Commit

Permalink
fix compilation error and clean up formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
TSFenwick committed Jun 12, 2024
1 parent 52b9555 commit f1ea266
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

public class DoubleDimensionIndexer implements DimensionIndexer<Double, Double, Double>
{

public static final Comparator<Double> DOUBLE_COMPARATOR = Comparators.naturalNullsFirst();
private final String dimensionName;
private volatile boolean hasNulls = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

public class LongDimensionIndexer implements DimensionIndexer<Long, Long, Long>
{

public static final Comparator<Long> LONG_COMPARATOR = Comparators.naturalNullsFirst();
private final String dimensionName;
private volatile boolean hasNulls = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ IncrementalIndexRowResult toIncrementalIndexRow(InputRow row)
Object dimsKey = null;
try {
final EncodedKeyComponent<?> encodedKeyComponent
= indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension), true, dimension);
= indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension), true);
dimsKey = encodedKeyComponent.getComponent();
dimsKeySize += encodedKeyComponent.getEffectiveSizeBytes();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private void processRows(

// Add 'null' to the dimension's dictionary.
if (dimIndex >= dims.length || dims[dimIndex] == null) {
accessor.indexer.processRowValsToUnsortedEncodedKeyComponent(null, true, dimension.getName());
accessor.indexer.processRowValsToUnsortedEncodedKeyComponent(null, true);
continue;
}
final ColumnCapabilities capabilities = dimension.getCapabilities();
Expand Down

0 comments on commit f1ea266

Please sign in to comment.