Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec #7397

Closed
justinborromeo opened this issue Apr 1, 2019 · 0 comments

Comments

@justinborromeo
Copy link
Contributor

justinborromeo commented Apr 1, 2019

Motivation

The configurable segment and row limits for time-ordered scans introduced in #7133 should be overridable through query parameters. Since memory usage is proportional to # of dimensions being queried, I think it makes sense to allow users to tune the limits based on the specific query they issue (as opposed to setting it in the config at startup). This would allow for greater flexibility from a user's perspective.

Proposed changes

I propose adding two optional fields maxRowsQueuedForOrdering and maxSegmentPartitionsOrderedInMemory to the scan query context. The default values will be their corresponding config properties.

Rationale

I don't think there's another way to do this

Operational impact

Likely none since #7133 hasn't been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant