Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec #7413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's more common in Druid to put these types of properties in the query context: |
|
@jon-wei moved params to query context |
jon-wei
reviewed
Apr 4, 2019
docs/content/querying/scan-query.md
Outdated
| |property|description|values|default| | ||
| |--------|-----------|------|-------| | ||
| |maxRowsQueuedForOrdering|The maximum number of rows returned when time ordering is used. Overrides the identically named config.|An integer in [0, 2147483647]|100000| |
There was a problem hiding this comment.
The default here would be the configured value of druid.query.scan.maxSegmentPartitionsOrderedInMemory instead of 100000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7397. Details are in the proposal.