Granularity: Introduce primitive-typed bucketStart, increment methods. #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves creation of unnecessary DateTime objects in timestamp_floor and timestamp_ceil expressions.
|
It looks like the CI failure was in the coverage checker. I pushed a new patch that improves test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves creation of unnecessary DateTime objects in timestamp_floor and
timestamp_ceil expressions.
I was running a query that had a
group by floor(__time to year)in it and was greeted by the following flame graph:33% of the time is spent on
DateTime.<init>. It's not necessary, because the PeriodGranularity code is doing the hard work on the primitive milliseconds.