Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show leader nodes in Services Tab #10951

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

FrankChen021
Copy link
Member

This PR is a replacement for #10418 .

The core changes at the server side in #10418 has been implemented in #10680, and based on that implementation, a is_leader column is added to 'servers' table which means user could know which nodes are playing in a role of leader by querying 'servers' table.

This PR provides a more convenient, intuitive way for users to get leader information - by showing the information in 'Details' column under 'Services' tab.

image

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: frank chen <frank.chen021@outlook.com>
@FrankChen021
Copy link
Member Author

Hi @vogievetsky , Could you help review this PR ?

Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants