S3 ingestion can assume role #10995
Merged
S3 ingestion can assume role #10995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "properties": { | ||
| "accessKeyId": "KLJ78979SDFdS2", | ||
| "secretAccessKey": "KLS89s98sKJHKJKJH8721lljkd", | ||
| "assumeRoleArn": "arn:aws:iam::2981002874992:role/role-s3" |
There was a problem hiding this comment.
I believe above are some dummy IDs and roles and not some actual ones.
| @JsonProperty | ||
| private PasswordProvider accessKeyId; | ||
| @JsonProperty | ||
| private PasswordProvider secretAccessKey; |
There was a problem hiding this comment.
accessKeyId and SecretAccessKey are also nullable, Can we add annotation these as well.
|
Fixed all except coverage. The code is integration with AWS API, writing mocks for it will effectively replace about 90% of code, which is unreasonable for testing. |
| @@ -115,8 +115,8 @@ | |||
| <dependency> | |||
| <groupId>com.amazonaws</groupId> | |||
| <artifactId>aws-java-sdk-sts</artifactId> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
aws-common doesn't contain it, surprisingly Kinesis extension contains it, when Kinesis ext. is removed then the S3 ext. fails.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows S3 ingestion to use the AssumeRole capability of AWS that helps with cross-account access.
It introduces 2 additional fields in S3InputSourceConfig (those are optional).
This PR has: