-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ZooKeeper 3.4 support + pass tests with Java 15 #11073
Conversation
for some reason travis-ci is not picking up this PR 🤔 |
reopening in the attempt to trigger a travis-ci build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concept looks good to me — we've already discussed that in #10780.
The code changes look good to me too.
A couple of questions:
-
We'll need to have something about this prominently in the release notes, but in addition, I think it'd be good to include it in the docs too. Can you update the docs somewhere to talk about the minimum ZK server version that we support, and the fact that it's been revved recently? Maybe in cluster.md and zookeeper.md.
-
Should we update Curator too?
Agree, I can add something to the docs to that effect.
There are a couple more breaking changes in curator 5.0, so we can deal with that separately. Additionally, it lets someone still run against ZK 3.4.x by replacing the client libraries in the classpath if needed. We can probably move to 5.x in Druid 0.23 |
@gianm added the docs, and rebased on the latest master to fix conflicts |
Is the milestone for this upgrade |
That's a good point, it'd be nice to retain the ability for people to drop in ZK 3.4 clients for some time. Maybe even a bit beyond Druid 0.23, if the new Curator doesn't offer much exciting stuff. |
With this change, Druid will only support ZooKeeper 3.5.x and later.
In order to support Java 15 we need to switch to ZK 3.5.x client libraries and drop support for ZK 3.4.x
(see #10780 for the detailed reasons)