Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web console: Better inline docs #11128

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Web console: Better inline docs #11128

merged 3 commits into from
Apr 19, 2021

Conversation

vogievetsky
Copy link
Contributor

Inline docs for types:

image

Also better highlight for CROSS join and more compact doc compiling.

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

jgoz
jgoz approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@jgoz jgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

clintropolis
clintropolis approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clintropolis clintropolis merged commit 4caa221 into apache:master Apr 19, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
@clintropolis clintropolis mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoz jgoz jgoz approved these changes

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Web Console
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vogievetsky @jgoz @clintropolis