Allow user to set group.id for Kafka ingestion task #11147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the section More on consumerProperties in kafka-ingestion.md needs to be updated to reflect the change in this PR ? |
updated |
asdf2014
reviewed
May 5, 2021
| @@ -40,6 +40,8 @@ This service is provided in the `druid-kafka-indexing-service` core Apache Druid | |||
| > In addition, users could set `isolation.level` `read_uncommitted` in `consumerProperties`, if don't need Druid to consume transactional topics or need Druid to consume older versions of Kafka. | |||
| > Make sure offsets are sequential, since there is no offset gap check in Druid anymore. | |||
|
|
|||
| > If your Kafka cluster enables ACLs, you can set `group.id` in `consumerProperties` to override the defualt auto generated group id. | |||
There was a problem hiding this comment.
After updating the doc, you may need to add the ACLs to the .spelling file, and then please use default instead of defualt.
FrankChen021
reviewed
May 7, 2021
Co-authored-by: frank chen <frankchen@apache.org>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8715.
Key changed/added classes in this PR
KafkaConsumerConfigsKafkaRecordSupplierKafkaIndexTaskThis PR has: