Web console: add more query fixing auto suggestions #11203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +51,13 @@ | |||
| "check-licenses": "license-checker --production --onlyAllow 'Apache-1.1;Apache-2.0;BSD-2-Clause;BSD-3-Clause;0BSD;MIT;CC0-1.0' --summary", | |||
| "start": "webpack serve --hot --open" | |||
| }, | |||
| "engines": { | |||
| "node": ">=14" | |||
There was a problem hiding this comment.
what does this stuff mean? do we need to update the nodejs version we use to build this when using maven? https://github.com/apache/druid/blob/master/pom.xml#L103 (this is also used by website builds afaik)
There was a problem hiding this comment.
This is too complex for me to think about... with the website interaction that is. I added it to inform the local dev tools. I think if you are developing on the web console locally you really want node > 10 for some of the dev dependancies. I will remove the engines entry.
clintropolis
approved these changes
Jun 3, 2021
clintropolis
approved these changes
Jun 4, 2021
|
Thank you for the review and the help with figuring out POM files @clintropolis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the auto suggestions for queries and just makes the query experience just a little bit better.
It also improves query intelligence when fractional indexes are used (like
GROUP BY 1.5) which is strange but supported by Druid/Calcite - who am I to judge?Syntax like
FETCH NEXT 5 ROWS ONLYis now supported in highlightingThis PR has: