-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web console: Remove support for IE11 and other older browsers #11357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogievetsky
reviewed
Jun 11, 2021
vogievetsky
reviewed
Jun 11, 2021
vogievetsky
reviewed
Jun 11, 2021
vogievetsky
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one wording suggestion but otherwise this looks great. Very excited about all the cool stuff we can do with the newer JS target
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some ES6 features, such as
Proxy
, that would make sense to use in various parts of the web console. Unfortunately, many of these cannot be polyfilled and therefore cannot be used in older browsers like IE11.Since IE11 will be officially retired in about 1 year and its rendering engine still exists inside of the new Edge for those who need it, there is no compelling reason to continue supporting it in the web console. Dropping IE and other browsers that lack ES6 support will both slim down the JS payload and allow us to use new ES features that have ostensibly been available for a few years in the majority of browsers.
Key changes
browserslist
declaration to include only those browsers that support ES6es2016
unified-console.html
if an unsupported browser is detected (using existence ofProxy
as a rough indicator of support)HotkeysTarget
usage (deprecated) withuseHotkeys
to avoid runtime error caused by dependence on ES5-style class behaviorThis PR has: