Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: Remove support for IE11 and other older browsers #11357

Merged
merged 12 commits into from
Jun 11, 2021

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Jun 10, 2021

Description

There are some ES6 features, such as Proxy, that would make sense to use in various parts of the web console. Unfortunately, many of these cannot be polyfilled and therefore cannot be used in older browsers like IE11.

Since IE11 will be officially retired in about 1 year and its rendering engine still exists inside of the new Edge for those who need it, there is no compelling reason to continue supporting it in the web console. Dropping IE and other browsers that lack ES6 support will both slim down the JS payload and allow us to use new ES features that have ostensibly been available for a few years in the majority of browsers.


Key changes
  • Consolidate and update browserslist declaration to include only those browsers that support ES6
  • Update TypeScript compilation target to es2016
  • Add a banner to unified-console.html if an unsupported browser is detected (using existence of Proxy as a rough indicator of support)
  • Replace HotkeysTarget usage (deprecated) with useHotkeys to avoid runtime error caused by dependence on ES5-style class behavior

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.
  • added or updated version, license, or notice information in licenses.yaml

Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one wording suggestion but otherwise this looks great. Very excited about all the cool stuff we can do with the newer JS target

Co-authored-by: Vadim Ogievetsky <vadimon@gmail.com>
@vogievetsky vogievetsky merged commit ac9b1f8 into apache:master Jun 11, 2021
@suneet-s
Copy link
Contributor

Added Release Notes label to warn users who might be using some of these older browsers. Hopefully no one :)

@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants