Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web console: Better hotkeys and library upgrades #11365

Merged
merged 9 commits into from
Jun 18, 2021
Merged

Web console: Better hotkeys and library upgrades #11365

merged 9 commits into from
Jun 18, 2021

Conversation

vogievetsky
Copy link
Contributor

Improved the hotkeys, letting you run queries with command + enter (on mac) and ctrl + enter (on windows).

In addition this PR:

This PR has:

  • been self-reviewed.
  • added integration tests.
  • been tested in a test Druid cluster.

jgoz
jgoz approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@jgoz jgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Really cool!

clintropolis
clintropolis approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vogievetsky
Copy link
Contributor Author

Thank you for the review, and for catching that strange interaction

@vogievetsky vogievetsky merged commit f56a5b9 into apache:master Jun 18, 2021
@vogievetsky vogievetsky deleted the hotkeys_and_more branch June 18, 2021 01:24
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
@clintropolis clintropolis mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoz jgoz jgoz approved these changes

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Web Console
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vogievetsky @jgoz @clintropolis