support jdbc even if trailing / is missing #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this as WIP because seeing some strange flakiness on Avatica unit tests, https://app.travis-ci.com/github/apache/druid/jobs/539085044#L2192 I don't really understand yet how the changes could cause that, but I can replicate locally and also don't see this behavior outside of this branch. |
finally got back to this, the issue seems to have been caused by the test having a maximum connection limit of 3, but the newly added connection made there be 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently JDBC connections to Druid require that the trailing
/be part of the request url so that it matches exactly, else it will not be handled by the avatica machinery. This isn't very user-friendly, this PR modifies the Avatica endpoint handlers to accept with or without the trailing /, e.g./druid/v2/sql/avatica/or/druid/v2/sql/avatica(and also protobuf).This PR has: