Add rollup config to auto and manual compaction #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Same indexSpec as what is set in the auto compaction config | ||
| Map<String, Object> indexSpec = mapper.convertValue(new IndexSpec(), new TypeReference<Map<String, Object>>() {}); | ||
| // Same partitionsSpec as what is set in the auto compaction config | ||
| PartitionsSpec partitionsSpec = NewestSegmentFirstIterator.findPartitinosSpecFromConfig(ClientCompactionTaskQueryTuningConfig.from(null, null)); |
There was a problem hiding this comment.
heh, there is a typo in there findPartitinosSpecFromConfig -> findPartitionsSpecFromConfig
| // rollup=false for interval 2017-10-01T00:00:00/2017-10-02T00:00:00, | ||
| // rollup=true for interval 2017-10-02T00:00:00/2017-10-03T00:00:00, | ||
| // and rollup=null for interval 2017-10-03T00:00:00/2017-10-04T00:00:00 | ||
| final VersionedIntervalTimeline<String, DataSegment> timeline = createTimeline( |
There was a problem hiding this comment.
should we add a test that segments in the same compaction state with rollup are not re-compacted? or is that covered automatically by another test?
There was a problem hiding this comment.
This test should also cover that case. Here we have:
- segments with interval 2017-10-01T00:00:00/2017-10-02T00:00:00 and rollup=false in compaction state
- segments with interval 2017-10-02T00:00:00/2017-10-03T00:00:00 and rollup=true in compaction state
- segments with interval 2017-10-03T00:00:00/2017-10-04T00:00:00 and rollup=null in compaction state (this means that the last time this segment/interval was compacted, the rollup value was not set in the auto compaction config).
Then we set auto compaction config with rollup=true.
We then expect that the segments with interval 2017-10-02T00:00:00/2017-10-03T00:00:00 are not returned since rollup in last compaction state is same as auto compaction config
We expect segments with interval 2017-10-01T00:00:00/2017-10-02T00:00:00 and segments with interval 2017-10-03T00:00:00/2017-10-04T00:00:00 to be returned.
There was a problem hiding this comment.
Is that what you are thinking or is it something else?
clintropolis
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rollup config to auto and manual compaction
Description
Add rollup to auto compaction and manual compaction.
This PR has: