skip raising false alert when the coordinator looses leadership #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip doing false alert when the coordinator looses leadership
| @@ -86,6 +86,7 @@ private static void executeCallbacks(List<LoadPeonCallback> callbacks) | |||
| private final Object lock = new Object(); | |||
|
|
|||
| private volatile SegmentHolder currentlyProcessing = null; | |||
| private boolean stopped = false; | |||
There was a problem hiding this comment.
all reads and writes are done within lock.
xvrl
added a commit
that referenced
this pull request
Apr 7, 2015
skip raising false alert when the coordinator looses leadership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip raising false alert when the coordinator looses leadership
fixes #1210