Removing MapWritableInputRowParser from indexing-hadoop #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly be an extension if user needs
|
Does anyone in the community use this? |
fjy
added a commit
that referenced
this pull request
Mar 20, 2015
Removing MapWritableInputRowParser from indexing-hadoop
|
@drcrallen no, it got checked in abt 30 mins before this PR |
|
@himanshug : awesome thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1177 . After my short discussion with @cheddar we decided we shouldn't really be supporting this parser inside indexing-hadoop . I removed it but @xvrl had merged the PR by then so it went in anyway.
it should really be an extension if user needs. I will probably open source it in a separate sample extension code on my github account as a reference implementation for writing InputRowParser .