Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default inputSegmentSizeBytes to Long.MAX_VALUE #12381

Merged

Conversation

tejaswini-imply
Copy link
Member

@tejaswini-imply tejaswini-imply commented Mar 30, 2022

Updates default inputSegmentSizeBytes in DataSourceCompactionConfig

Updates default inputSegmentSizeBytes to Long.MAX_VALUE and drops it from auto-compaction configuration form in console.


Key changed/added classes in this PR
  • DataSourceCompactionConfig
  • compaction-config.tsx

Tests done to verify the upgrade won't break any new or existing compaction tasks
  • Auto-compaction testing on a datasource with total candidates size to compact around 1 GB > existing default inputSegmentSizeBytes (400 MB) errored out with java.lang.OutOfMemoryError: Java heap space but passed after reducing maxBytesInMemory or maxRowsInMemory parameters.
  • Verified that existing auto-compaction configuration are reflecting the submitted values after console upgrade (dropping inputSegmentSizeBytes config and it's default value from auto-compaction console form)

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz marked this pull request as ready for review March 30, 2022 05:50
…rm and changing DEFAULT_INPUT_SEGMENT_SIZE_BYTES to Long.MAX_VALUE
@tejaswini-imply tejaswini-imply changed the title Updating default inputSegmentSizeBytes to 100 TB in console Updating default inputSegmentSizeBytes to Long.MAX_VALUE Apr 4, 2022
Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @tejaswini-imply .
Please update the default value in the docs too.

Please also add info about the testing done for validating behaviour with the new default value.
How will this affect upgrade? Will the compaction of existing datasources be affected?

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kfaraz kfaraz merged commit 9849047 into apache:master Apr 4, 2022
TSFenwick pushed a commit to TSFenwick/druid that referenced this pull request Apr 11, 2022
…Long.MAX_VALUE (apache#12381)

The current default value of inputSegmentSizeBytes is 400MB, which is pretty
low for most compaction use cases. Thus most users are forced to override the
default.

The default value is now increased to Long.MAX_VALUE.
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants