print replication levels in coordinator segment logs #12511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves coordinator load rule logging to include current replication levels, and adds missing segment id and tier information from some of the log messages. I've seen some strange behavior where segments become very over-replicated, particularly when multiple tiers are involved, but sometimes even when not, and am hoping these logging improvements can help track down the issue.
These logs should will print replication for all tiers, as well as consistently provide segment id and tier information:
Also fixes a confusing log message about skipping drops which prior to this PR would always print if a segment was under-replicated on any tier, even if there was no tier to drop it from. Now this log message should only print when there is actually something to drop, as well as includes segmentId and from what tier the drop was skipped.
Finally, I've added currently served segment count to the
EmitClusterStatsAndMetrics
server details: