-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates default inputSegmentSizeBytes in Compaction config #12534
Updates default inputSegmentSizeBytes in Compaction config #12534
Conversation
@tejaswini-imply This was very annoying. Thanks for the fix !!. Hope you have tested it locally !! |
Marking it for |
Yes, @cryptoe. When I tested it locally the updated default value is reflected in the console after submitting the compaction config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @tejaswini-imply. Can you also backport it to |
Fixes
Cannot serialize BigInt value as JSON
error while loading compaction config in console.Description
The reason this error is occurring is that the current default value of inputSegmentSizeBytes is
Long.MAX_VALUE
. Numbers overNumber.MAX_SAFE_INTEGER
(9,007,199,254,740,991) may not be handled by few clients like JS.Hence reducing the default
inputSegmentSizeBytes
fromLong.MAX_VALUE
to 100,000,000,000,000 (~100TB).Key changed/added classes in this PR
DataSourceCompactionConfig
This PR has: